Simpler indexing in JAX DQN#537
Closed
joelberkeley wants to merge 1 commit into
Closed
Conversation
|
@joelberkeley is attempting to deploy a commit to the Costa Huang's projects Team on Vercel. A member of the Team first needs to authorize it. |
This was referenced Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Since this is a "clean" RL repo I thought it might help to improve readability. If this PR is too small to be worthwhile, that's fine.
I don't believe this should affect performance or functionality.
I've not read the contributing guidelines properly. If that's a blocker, feel free to reject PR.
I didn't work out how to get the dependencies to work, so I didn't re-run the file as a smoke test
Types of changes
Readability - none of the below
Checklist:
pre-commit run --all-filespasses (required).mkdocs serve.